Open
Conversation
jay-zahiri
force-pushed
the
StoreObjects
branch
from
3963e56 to
5ff82b4
Compare
Member
|
@jay-zahiri Can you add a test for this, and I'll pick this up on 3.6? 3.5 today, but 3.6 by the end of this week |
Contributor
Author
|
Will do! I'll probably add them Thursday, swamped til then |
jay-zahiri
force-pushed
the
StoreObjects
branch
from
78c0359 to
1480c1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially breaking change
If a user is performing any tests on the actual list type, this PR might break it. In this PR
StoreManyDocsandStoreObjectsinherit the same base class,Documents– which holds the actual list of objects to be stored (IReadOnlyList<object> Documents). I chose this in order to have a single point of source. SoStoreManyDocsno longer holds its own list of objects (readonly T[] _documents). Hope I made sense xD